feat: replace bootstrap node if bucket full #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
reviewed
Dec 6, 2023
joshuef
approved these changes
Dec 6, 2023
maqi
force-pushed
the
try_to_replace_bootstrap_nodes
branch
from
8e2e7a3
to
2c74ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 06 Dec 23 10:25 UTC
This pull request includes a feature that replaces a bootstrap node if the bucket is full. It modifies multiple files in the sn_networking library, including cmd.rs, driver.rs, event.rs, and lib.rs. The changes involve adding logic to check if a dial peer is a bootstrap node and replacing it if necessary, as well as removing a bootstrap node from a full bucket if present.