feat(ci): don't log raw data #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
reviewed
Dec 11, 2023
.github/workflows/nightly.yml
Outdated
| shell: bash | ||
| timeout-minutes: 20 | ||
| run: | | ||
| if rg '^' "${{ matrix.safe_path }}"/*/*/logs | awk 'length($0) > 15000 { print; exit 1 }' |
There was a problem hiding this comment.
why 15000 here and not 2k?
There was a problem hiding this comment.
Ah I was testing it out. I was going for 15k chars as the limit.
On a local run, I can se log lines upto 4k-5k chars. So 15k seems like something that we might possibly log. Raw data should contain upwards of 100k chars, so this might be a reasonable value to detect outliers but not trigger false positives.
joshuef
reviewed
Dec 11, 2023
.github/workflows/nightly.yml
Outdated
| shell: bash | ||
| timeout-minutes: 20 | ||
| run: | | ||
| if rg '^' "${{ matrix.safe_path }}"/*/*/logs | awk 'length($0) > 15000 { print; exit 1 }' |
RolandSherwin
force-pushed
the
dont_log_long_lines
branch
5 times, most recently
from
7f28534
to
d612fd1
Compare
joshuef
approved these changes
Dec 11, 2023
RolandSherwin
force-pushed
the
dont_log_long_lines
branch
3 times, most recently
from
03fcd9b
to
f0d7ac1
Compare
RolandSherwin
force-pushed
the
dont_log_long_lines
branch
from
f0d7ac1
to
2a80b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 11 Dec 23 10:59 UTC
This pull request adds a feature to the CI workflow. It modifies the merge.yml and nightly.yml files to prevent logging of raw data. It includes new steps in the workflow that check the length of the logs and exit with an error message if the length exceeds a certain threshold. The safe_path is also defined for each operating system.