feat(cli): skip payment and upload for existing chunks #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
force-pushed
the
skip_existing_chunks
branch
from
6f51e13
to
4d9f8f1
Compare
joshuef
reviewed
Dec 12, 2023
| cat transfer_hex | ||
| cargo run --bin safe --release -- --log-output-dest=data-dir wallet receive --file transfer_hex | ||
| cargo run --bin safe --release -- --log-output-dest=data-dir files upload "./the-test-data.zip" --show-holders > second_upload.txt | ||
| cat second_upload.txt |
There was a problem hiding this comment.
can we make this a full test and check the output here has no spend? (or am I missing that?)
There was a problem hiding this comment.
added an rg check to confirm the balance of wallet remain unchanged
joshuef
reviewed
Dec 12, 2023
joshuef
reviewed
Dec 12, 2023
joshuef
approved these changes
Dec 12, 2023
maqi
force-pushed
the
skip_existing_chunks
branch
from
4d9f8f1
to
7a62d60
Compare
joshuef
approved these changes
Dec 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 12 Dec 23 13:13 UTC
This pull request includes the following changes:
sn_climodule to handle the verification of chunks and payment for storage.sn_clientmodule to handle payment for chunks and storage, and added a function to skip existing chunks during payment.sn_clientmodule to handle payment for storage in theClientRegisterstruct.sn_clientmodule to add a list of existing chunks that need to be skipped during payment for storage.sn_clientmodule to return a list of skipped chunks during payment for storage.sn_nodemodule to handle storage payment proofs cached in the wallet.storage_paymentsmodule to reflect the changes in payment for storage.Overall, these changes improve the handling of payment for storage and the verification of chunks in the code.