chore(cli): tidy cli output by removing peers list #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iancoleman
changed the title
joshuef
approved these changes
Dec 14, 2023
|
nice one 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small ergonomic improvements to the cli output.
I tried to copy the address when calling
safe wallet get-faucetby double clicking the address and it also included the...at the end of the address.The peer list is not useful and is very long so can be removed from the output. Might be useful to add a
safe peerscommand or something like that to list peers? Related to #1007Summary generated by Reviewpad on 13 Dec 23 20:48 UTC
This pull request includes two patches.
The first patch updates the code in the main.rs file to improve the stdout output when connecting to the network with peers. Instead of printing each individual peer, it now prints the number of peers.
The second patch modifies the wallet.rs file to remove the unnecessary ellipsis in the println statement, making it easier to copy the wallet address.