feat(client): extra sleep between chunk verification #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you clarify why we need this? |
joshuef
approved these changes
Jan 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 09 Jan 24 09:29 UTC
This pull request introduces a new feature to the client code. Specifically, it adds an extra sleep between chunk verification in the
sn_networkingmodule. This sleep is added to avoid firing queries too close together and potentially choking the nodes further. The waiting time is determined based on the number of retry attempts. Additionally, this patch includes a minor change in thesn_transfersmodule, where a debug message is added to indicate the path where the cash note is being written.