Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): refactor client upload flow #1162

Merged
merged 1 commit into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -500,12 +500,12 @@ jobs:
run: cargo test --release -p sn_node --features="local-discovery" --test verify_routing_table -- --nocapture
timeout-minutes: 5

- name: Verify the location of the data on the network (4 * 5 mins)
- name: Verify the location of the data on the network
run: cargo test --release -p sn_node --features="local-discovery" --test verify_data_location -- --nocapture
env:
CHURN_COUNT: 3
SN_LOG: "all"
timeout-minutes: 30
timeout-minutes: 5

- name: Verify the routing tables of the nodes
run: cargo test --release -p sn_node --features="local-discovery" --test verify_routing_table -- --nocapture
Expand Down Expand Up @@ -628,16 +628,17 @@ jobs:
run: cargo run --bin safe --release -- --log-output-dest=data-dir files upload "./test_data_1.tar.gz" -r 0
env:
SN_LOG: "all"
timeout-minutes: 60
timeout-minutes: 5

- name: Wait for certain period
run: sleep 300
timeout-minutes: 6

- name: Start a client to upload second file
run: cargo run --bin safe --release -- --log-output-dest=data-dir files upload "./test_data_2.tar.gz" -r 0
env:
SN_LOG: "all"
timeout-minutes: 60
timeout-minutes: 10

- name: Stop the local network and upload logs
if: always()
Expand Down
6 changes: 6 additions & 0 deletions sn_client/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,10 @@ pub enum Error {

#[error("Error occurred while assembling the downloaded chunks")]
FailedToAssembleDownloadedChunks,

#[error("Error occurred when access wallet file")]
FailedToAccessWallet,

#[error("Task completion notification channel is done")]
FailedToReadFromNotificationChannel,
}