New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(faucet): fetch maid pubkeys to enable encryption of distributions #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
reviewed
Jan 19, 2024
grumbach
reviewed
Jan 22, 2024
Reviewpad Report
|
@joshuef I'm happy with where this is at, all the comments have been addressed. Once it's in I'll start on the next step of the process. |
Aye, i was planning on holding this off until |
joshuef
approved these changes
Jan 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faucet will distribute tokens to existing maid holders (from the snapshot).
Each distribution will be encrypted using the maid public key, so only the maid owner can decrypt their distribution.
This feature enables an initial set of public keys to be used for the initial distribution. This means the live faucet will hold less tokens at start, since those distributions will be spent to maid owners when the faucet starts.
This doesn't create the distributions, but is an essential step toward it.
Description
Summary generated by Reviewpad on 19 Jan 24 02:03 UTC
This pull request includes the following changes:
Cargo.toml
- Added a new dependency onbitcoin
version0.31.0
.faucet_server.rs
- Various changes including imports, function additions/updates, and logging statements. Detailed changes provided in the previous message.Cargo.lock
- Multiple changes including package additions and updates. Detailed changes provided in the previous message.Please review the above changes and let me know if you need further assistance.