Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(faucet): fetch maid pubkeys to enable encryption of distributions #1210

Merged
merged 8 commits into from Jan 29, 2024

Conversation

iancoleman
Copy link
Contributor

@iancoleman iancoleman commented Jan 19, 2024

Faucet will distribute tokens to existing maid holders (from the snapshot).

Each distribution will be encrypted using the maid public key, so only the maid owner can decrypt their distribution.

This feature enables an initial set of public keys to be used for the initial distribution. This means the live faucet will hold less tokens at start, since those distributions will be spent to maid owners when the faucet starts.

This doesn't create the distributions, but is an essential step toward it.

Description

Summary generated by Reviewpad on 19 Jan 24 02:03 UTC

This pull request includes the following changes:

  1. Cargo.toml - Added a new dependency on bitcoin version 0.31.0.
  2. faucet_server.rs - Various changes including imports, function additions/updates, and logging statements. Detailed changes provided in the previous message.
  3. Cargo.lock - Multiple changes including package additions and updates. Detailed changes provided in the previous message.

Please review the above changes and let me know if you need further assistance.

@reviewpad reviewpad bot requested a review from bochaco January 19, 2024 02:03
@reviewpad reviewpad bot added Medium Medium sized PR waiting-for-review labels Jan 19, 2024
sn_faucet/src/faucet_server.rs Outdated Show resolved Hide resolved
sn_faucet/src/faucet_server.rs Outdated Show resolved Hide resolved
sn_faucet/src/faucet_server.rs Show resolved Hide resolved
@reviewpad reviewpad bot added Large Large sized PR and removed Medium Medium sized PR labels Jan 22, 2024
Copy link

reviewpad bot commented Jan 23, 2024

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'Merge branch 'main' into faucet_pubkeys' (bb669de)
  • Unconventional commit detected: 'Merge branch 'main' into faucet_pubkeys' (d689ad5)
  • Unconventional commit detected: 'Merge branch 'main' into faucet_pubkeys' (fdc5fcb)

⚠️ Warnings

  • Please rebase your pull request on the latest changes

@iancoleman
Copy link
Contributor Author

@joshuef I'm happy with where this is at, all the comments have been addressed. Once it's in I'll start on the next step of the process.

@joshuef
Copy link
Contributor

joshuef commented Jan 29, 2024

Aye, i was planning on holding this off until quic had been tested, but we can roll it all in together as the deployer is tripping us up the last week, so I won't hold you up here any longer 👍

@joshuef joshuef added this pull request to the merge queue Jan 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2024
@joshuef joshuef added this pull request to the merge queue Jan 29, 2024
Merged via the queue into maidsafe:main with commit a144b3e Jan 29, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Large Large sized PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants