feat: client side dag #1259
feat: client side dag #1259
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Ok(s) => s, | ||
| Err(Error::MissingSpendRecord(_)) => { | ||
| trace!("UTXO at {spend_addr:?}"); | ||
| return Ok(dag); |
There was a problem hiding this comment.
1, Why it's not an error to be returned if spend not found ?
2, The comment of the function doesn't explain this situation
if it's a value return, maybe put an explaination in the function comment ?
There was a problem hiding this comment.
If a Spend is not found, it means the CashNote was not spent yet. This is not an error in our DAG building, it simply indicates there is no need to fetch further as unspent money has no descendants.
|
|
||
| /// Extends an existing SpendDag starting from the utxos in this DAG | ||
| /// Covers the entirety of currently existing Spends if the DAG was built from Genesis | ||
| pub async fn spend_dag_continue_from_utxos(&self, dag: &mut SpendDag) -> WalletResult<()> { |
There was a problem hiding this comment.
hmm... what's the different between this to be above spend_dag_extend function ?
continue_from_utxos is also an extend ?
maybe the spend_dag_extend shall be renamed to dag_from_spend_address ?
There was a problem hiding this comment.
Yeah I agree, basically spend_dag_continue_from_utxos extends the DAG in all directions from the current UTXOs at the extremities. That's total collection, the point of this is to collect all Spends that exist on the Network.
spend_dag_extend is partial extension from one spend back to either Genesis or a known Spend that we already have in our DAG. It is adding one Spend and all its ancestors to our current DAG.
So both are extension, but one is only in one direction up to a specific Spend and the other one is in all directions.
dag_from_spend_address makes me think that we build a dag from an address, maybe we need to add an extend somewhere.
How is spend_dag_extend_until?
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
grumbach
force-pushed
the
dag_client_side
branch
from
326d757
to
3d194ff
Compare
Description
reviewpad:summary