chore: improvements from dev feedback #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacderida
force-pushed
the
local-network-improvments
branch
from
cb2f469
to
a69b0c5
Compare
joshuef
approved these changes
Feb 7, 2024
jacderida
force-pushed
the
local-network-improvments
branch
3 times, most recently
from
19f9365
to
de85a0a
Compare
Reduce the start up time for the local network by removing the wait in the `get_available_port` function. This function is now only being used to select ports for the RPC service, so it shouldn't be subject to the same problems we had with the node when it switched over to Quic. Also, the `--clean` argument on the run command has been extended to kill any existing local network.
jacderida
force-pushed
the
local-network-improvments
branch
from
de85a0a
to
5197510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the start up time for the local network by removing the wait in the
get_available_portfunction. This function is now only being used to select ports for the RPC service, so it shouldn't be subject to the same problems we had with the node when it switched over to Quic.Also, the
--cleanargument on the run command has been extended to kill any existing local network.Description
reviewpad:summary