ci: upload binaries to s3 before publish #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found CI node manager upgrade tests did not work correctly when a release was running at the same time, which is a common scenario. The reason is because the node manager uses `crates.io` to get the latest version of the node and then attempts to download binaries from S3 based on that version number, but those binaries were not yet available on S3. We now change the process to upload the binaries to S3 before the publishing phase.
RolandSherwin
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found CI node manager upgrade tests did not work correctly when a release was running at the same time, which is a common scenario. The reason is because the node manager uses
crates.ioto get the latest version of the node and then attempts to download binaries from S3 based on that version number, but those binaries were not yet available on S3.We now change the process to upload the binaries to S3 before the publishing phase.
Description
reviewpad:summary