Update main from alpha #1389
Update main from alpha #1389
Conversation
… from the network
The bitcoin maid address is used to sign a safe wallet address. Distributions are sent to the signed safe wallet address. This removes the need for ecies encryption/decryption. This also removes the need to have the maid private key available.
A new `faucet` subcommand is introduced, enabling the faucet to be controlled as a service. This is necessary because as with nodes, the faucet also needs to be upgraded on a new deployment; it may also require downgrading in the event of a problem. The existing `faucet` command, which was created as a utility for the backwards compatibility test, is removed; now that we can define the faucet as a service, it will no longer be necessary. The function that determines the data directory for the faucet was being duplicated in two different crates, and the node manager would have added a third, so it was refactored as public in `sn_transfers` and shared from there.
This command is quite similar to the `start` command for starting a node service, but my judgement is there probably isn't enough code that is common between them to extract out something more generic. BREAKING CHANGE: the `faucet_pid` field of the node registry was removed in favour of a `faucet` field, which provides more details, including the PID.
Rather than having a `faucet` module within `node_control`, I thought it made sense to also have a `faucet_control` module, and I've organised it the same as `node_control`.
As with the `faucet start` command, this provides the corresponding `stop` command. I revisited the idea of sharing code between the node and faucet services, but again came to the conclusion that there wasn't much value added for the complexity it introduced. The result is that we have code between them that only has small differences, but I think this is OK for now.
…node-manager bucket
Bumps [actions/cache](https://github.com/actions/cache) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4.0.0...v4.0.1) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| }, | ||
| Ok(None) => { | ||
| // TODO: we need to encrypt the data-map and metadata if make_data_public is false. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| } | ||
| FolderEntry::Folder(_) => { | ||
| // New file found where there used to be a folder | ||
| // TODO: we need to encrypt the data-map and metadata if make_data_public is false. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| Ok(Some(tracking_info)) => match &tracking_info.metadata.content { | ||
| FolderEntry::File(chunk) => { | ||
| if chunk.address() != &chunked_file.head_chunk_address { | ||
| // TODO: we need to encrypt the data-map and metadata if make_data_public is false. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
|
||
| // Scan existing files and folders on disk, generating a report of all the detected | ||
| // changes based on the tracking info kept locally. | ||
| // TODO: encrypt the data-map and metadata if make_data_public is false. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
|
||
| /// Object which allows a user to store and manage files, wallets, etc., with the ability | ||
| /// and tols necessary to keep a local instance in sync with its remote version stored on the network. | ||
| /// TODO: currently only files and folders are supported, wallets, keys, etc., to be added later. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| } | ||
|
|
||
| // Information stored locally to keep track of local changes to files/folders. | ||
| // TODO: to make file changes discovery more efficient, and prevent chunking for |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| .arg("--count") | ||
| .arg("3") | ||
| .arg("--peer") | ||
| .arg("/ip4/127.0.0.1/udp/46091/p2p/12D3KooWAWnbQLxqspWeB3M8HB3ab3CSj6FYzsJxEG9XdVnGNCod") |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
|
|
||
| /// Sync local changes made to files and folder with their version on the network, | ||
| /// pushing changes made locally to the network. | ||
| // TODO: download/pull changes and files from network version. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| ); | ||
| } | ||
|
|
||
| // TODO: merge what we'll retrieve from network into what exists locally |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
Description
reviewpad:summary