New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor spend validation #1400
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
force-pushed
the
refactor_spent_verification
branch
from
March 7, 2024 02:12
03edfb5
to
51e88c4
Compare
Instead of downloading to dirs_next::download_dir() the path specified by the input is respected, either relative or absolute path. eg `safe files download myfile.txt ADDR` Destination before this PR: $HOME/download/myfile.txt Destination after this PR: $PWD/myfile.txt `safe files download my/relative/dir/myfile.txt ADDR` Destination before this PR: $HOME/download/my/relative/dir/myfile.txt Destination after this PR: $PWD/my/relative/dir/myfile.txt `safe files download /tmp/myfile.txt ADDR` Destination before this PR: $HOME/download/tmp/myfile.txt Destination after this PR: /tmp/myfile.txt Discussion of this by community: https://safenetforum.org/t/newyearnewnet-04-01-2024-testnet-offline/39034/455
…ge them to local version
…nd syncing on/with network
…13.30/sn_protocol-v0.15.1/sn_transfers-v0.16.2/sn_faucet-v0.3.81/sn_node-v0.104.36/sn-node-manager-v0.4.1/sn_node_rpc_client-v0.4.68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviewpad:summary