Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor spend validation #1400

Closed
wants to merge 16 commits into from

Conversation

grumbach
Copy link
Member

@grumbach grumbach commented Mar 6, 2024

Description

  • better, faster, stronger

reviewpad:summary

@grumbach grumbach marked this pull request as draft March 6, 2024 11:06
@grumbach grumbach force-pushed the refactor_spent_verification branch from 03edfb5 to 51e88c4 Compare March 7, 2024 02:12
iancoleman and others added 15 commits March 7, 2024 11:12
Instead of downloading to dirs_next::download_dir() the path specified
by the input is respected, either relative or absolute path.

eg
`safe files download myfile.txt ADDR`
Destination before this PR: $HOME/download/myfile.txt
Destination after this PR: $PWD/myfile.txt

`safe files download my/relative/dir/myfile.txt ADDR`
Destination before this PR: $HOME/download/my/relative/dir/myfile.txt
Destination after this PR: $PWD/my/relative/dir/myfile.txt

`safe files download /tmp/myfile.txt ADDR`
Destination before this PR: $HOME/download/tmp/myfile.txt
Destination after this PR: /tmp/myfile.txt

Discussion of this by community:
https://safenetforum.org/t/newyearnewnet-04-01-2024-testnet-offline/39034/455
…13.30/sn_protocol-v0.15.1/sn_transfers-v0.16.2/sn_faucet-v0.3.81/sn_node-v0.104.36/sn-node-manager-v0.4.1/sn_node_rpc_client-v0.4.68
@grumbach grumbach closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants