feat(networking): Add WebSocket as extra transport (multitransport) #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
b-zee
commented
Mar 11, 2024
b-zee
commented
- feat(networking): support fallback WS transport
- feat(networking): listen on WS addr too
When `websockets` is enabled, we add this with `or_transport` so as to support both QUIC and WS simultaneously. The code is a bit refactored into a separate module with files, as it's a little cleaner with the conditional compilation flags for wasm32.
|
@b-zee does this always give us two transports? Or is it optional? (should it be?) |
Only with |
No, i don't think so. At least not yet. |
joshuef
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.