chunks to upload to chunks manager with boolean workaround #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JasonPaulGithub
force-pushed
the
ctu_to_mgr
branch
from
012e673
to
18682f6
Compare
JasonPaulGithub
changed the title
JasonPaulGithub
force-pushed
the
ctu_to_mgr
branch
from
1391d3a
to
a583d2e
Compare
maqi
reviewed
Mar 12, 2024
JasonPaulGithub
force-pushed
the
ctu_to_mgr
branch
from
a583d2e
to
f656f35
Compare
maqi
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've made things a little more generic by moving out the
chunks to uploadfrom theiterative uploadfunction. The result satisfies both theuploadand theacc paccode that uses it.I plan to work this further and rearrange the way
chunk managerandfiles apiis used. but this will do for now.messagingcode will be tidied upThis will affect code by @bochaco a little bit
Functions should do only one thing, so I've removed the counter feature inside the
iterative uploader. That's a cool way to do it but the need for a counter has been decoupled.I know it's not good to use the boolean flag for a different response. We're going to need to bridge the gap between
acc pacanduploadover its mutual use ofiterative upload. They are using it in the same way yet require a separate response. Polymorphism / a builder can solve this. Either way the boolean flag we have will have to do for now as things aren't that complicated.