feat: make logging simpler to use #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
commented
Mar 25, 2024
sn_logging/src/lib.rs
Outdated
Comment on lines
61
to
73
| .join("safe") | ||
| .join(curent_exe_name()) | ||
| .join("logs") | ||
| .join(format!("log_{timestamp}")), |
There was a problem hiding this comment.
Log to safe/[exe_name]/logs/
so any app can use it and the path depends on app name.
grumbach
force-pushed
the
simple_logging
branch
2 times, most recently
from
734b870
to
40e64de
Compare
grumbach
force-pushed
the
simple_logging
branch
from
9b9db26
to
78978f3
Compare
sn_logging/src/lib.rs
Outdated
| #[derive(Debug, Clone)] | ||
| pub enum LogOutputDest { | ||
| Stdout, | ||
| Path(PathBuf), | ||
| } | ||
|
|
||
| fn curent_exe_name() -> String { |
RolandSherwin
approved these changes
Mar 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sn_logginguseagereviewpad:summary