chore(node): refactor pricing metrics #1501
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /// number of times that got paid | ||
| pub received_payment_count: usize, | ||
| /// the duration that node keeps connected to the network, measured in hours | ||
| /// TODO: take `restart` into accout |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| .store_mut() | ||
| .contains(&key); | ||
| let cost = if record_exists { | ||
| NanoTokens::zero() |
There was a problem hiding this comment.
Have we not lost the 0 cost if record exists here?
There was a problem hiding this comment.
no, will still return Zero cost within the inner calculation.
|
I see the main aim here is the |
Ok, will update this once PR 1497 merged. |
Description
reviewpad:summary