feat(cli): derive keys for Client signing ops, metadata chunks encryption, and for acc-packet root folder xorname #1509
Conversation
bochaco
force-pushed
the
feat-acc-packet-derive-encryption-signing-keys
branch
3 times, most recently
from
cbb7cac
to
8b8ea72
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /// TODO: allow to provide specific keys, and/or a way to derive keys, for encrypting and siging operations. Currently | ||
| /// the provided Client's key is used for both encrypting data and signing network operations. | ||
| /// | ||
| /// TODO: make use of eip2333 paths for deriving keys. Currently keys used for encrypting and signing |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| /// - Sign all data operations sent to the network. | ||
| /// - Set it as the owner of all Folders (Registers) created on the network. | ||
| /// - Encrypt all the Folders entries metadata chunks. | ||
| // TODO: use eip2333 path for deriving keys |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @@ -42,15 +42,28 @@ | |||
| use walkdir::{DirEntry, WalkDir}; | |||
| use xor_name::XorName; | |||
|
|
|||
| /// Derivation index used to obtain the account packet root folder xorname | |||
| // TODO: use eip2333 path for deriving keys | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
bochaco
force-pushed
the
feat-acc-packet-derive-encryption-signing-keys
branch
from
8b8ea72
to
5b2e70c
Compare
| } | ||
|
|
||
| // Read the root seed/SK from disk | ||
| // TODO: decrypt the SK with a password |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @@ -146,6 +153,31 @@ | |||
| Ok(()) | |||
| } | |||
|
|
|||
| // Store the given root seed/SK on disk | |||
| // TODO: encrypt the SK with a password | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @@ -864,20 +890,51 @@ | |||
| .map(|(meta_xorname, _)| *meta_xorname) | |||
| } | |||
|
|
|||
| // Using the provided root SK, derive client signer SK and the root Folder address from it. | |||
| // It returns the Client updated with the derived signing key set, along with the derived Register address. | |||
| // TODO: use eip2333 path for deriving keys and address. | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| /// All keys used for encrypting the files/folders metadata chunks and signing | ||
| /// operations are derived from the root key provided using index derivation. | ||
| /// The root Folder address and owner are also derived from the root SK. | ||
| /// TODO: A password can be optionally provided to encrypt the root SK before storing it on disk. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
bochaco
force-pushed
the
feat-acc-packet-derive-encryption-signing-keys
branch
from
d03519a
to
6da5d6c
Compare
bochaco
force-pushed
the
feat-acc-packet-derive-encryption-signing-keys
branch
from
6da5d6c
to
7afdd6b
Compare
bochaco
force-pushed
the
feat-acc-packet-derive-encryption-signing-keys
branch
from
7afdd6b
to
e900fad
Compare
Description
reviewpad:summary