feat: include output DBC within payment proof for Chunks storage #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Reason-hash value set in the input/parent DBCs spent for this storage payment. | ||
| // TOOD: pass the output DBC instead, nodes can check input/parent DBCs' reason-hash among other pending validations. | ||
| // TODO: remove it since nodes should get this from the input/parent spent DBC/s |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
bochaco
force-pushed
the
feat-attach-dbc-within-payment-proof
branch
5 times, most recently
from
72790b6
to
bb941fe
Compare
bochaco
force-pushed
the
feat-attach-dbc-within-payment-proof
branch
2 times, most recently
from
fa5b8ed
to
a620bc2
Compare
joshuef
approved these changes
Jun 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bochaco
force-pushed
the
feat-attach-dbc-within-payment-proof
branch
from
a620bc2
to
1955c82
Compare
bochaco
commented
Jun 13, 2023
| @@ -103,11 +103,14 @@ pub type MerkleTreeNodesType = [u8; 32]; | |||
|
|
|||
| #[derive(Clone, Eq, PartialEq, Serialize, Deserialize, custom_debug::Debug)] | |||
| pub struct PaymentProof { | |||
| // Output DBC for nodes to check the Chunk payment is valid and inputs have | |||
| // been effectivelly spent on the network. | |||
| pub dbc: Dbc, | |||
There was a problem hiding this comment.
...I believe we'll need a Vec<Dbc> here actually, I'll take care of that on later PRs since this is likely to change anyways.
bochaco
force-pushed
the
feat-attach-dbc-within-payment-proof
branch
from
1955c82
to
db3c288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #342
Description
Summary generated by Reviewpad on 08 Jun 23 14:35 UTC
This pull request includes various changes across multiple files related to the
PaymentProofsMaptype. It adds new fields and modifies the return types of some functions. It also removes some unused imports and changes imports from one module to another. Additionally, it updates theCmdResponse::StoreChunkfunction in thesn_protocolmodule to accept payment proofs. Finally, it modifies thePaymentProofstruct in thesn_protocolmodule to add a new fielddbcand update theaudit_trailfield.