fix(replication): prevent dropped conns during replication #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
approved these changes
Jun 9, 2023
We were seeing a lot of OutboundFialure and closed connections leading to dropped messages during data replication. This was turning up as UnexpectedEof errors when a connection was closed midway through send eg. Seems like, due to _NOT_ responding to a request (using the protocol wrongly perhaps?) we were causing awaiting connections to error out as the receive stream was dropped unepectedly, causing a knock on to anything else in flight on that same connection.
maqi
force-pushed
the
FixOutboundFailProliferation
branch
from
f527fe0
to
980688f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing a lot of OutboundFialure and closed connections leading to dropped messages during data replication. This was turning up as UnexpectedEof errors when a connection was closed midway through send eg.
Seems like, due to NOT responding to a request (using the protocol wrongly perhaps?) we were causing awaiting connections to error out as the receive stream was dropped unepectedly, causing a knock on to anything else in flight on that same connection.
Description
Summary generated by Reviewpad on 09 Jun 23 02:32 UTC
This pull request fixes dropped messages during data replication due to closed connections from outbound failures. The change includes adding a response to the ReplicateCmd to prevent connection failures and errors in awaiting connections.