refactor: chunk files only once when making payment for their storage #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let client = self.client.clone(); | ||
| let chunk_addr = *chunk.address(); | ||
| let payment = payment_proofs.get(chunk_addr.name()).cloned(); | ||
| // TODO: re-enable requirement to always provide payment proof |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
bochaco
force-pushed
the
refactor-chunk-files-once-when-making-storage-payment
branch
4 times, most recently
from
f56da96
to
c58db73
Compare
| value: Bytes::from(file), | ||
| }), | ||
| (_, Err(err)) => { | ||
| // FIXME: this error won't be seen/reported, thus assumed all chunks were read and stored. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| client: &Client, | ||
| root_dir: &Path, | ||
| files_path: &Path, | ||
| ) -> Result<PaymentProofsMap> { | ||
| pay: bool, // TODO: to be removed; temporarily payment is optional |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
bochaco
force-pushed
the
refactor-chunk-files-once-when-making-storage-payment
branch
3 times, most recently
from
fcb4001
to
b46fcdc
Compare
bochaco
force-pushed
the
refactor-chunk-files-once-when-making-storage-payment
branch
from
b46fcdc
to
722ac36
Compare
joshuef
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #340 .
Description
Summary generated by Reviewpad on 10 Jul 23 17:45 UTC
This pull request refactors the code related to making payments for storage when chunking files. It includes changes to the
files.rsandwallet.rsfiles.In the
files.rsfile, theupload_filesfunction has been modified to chunk and store files in a more efficient way. Instead of chunking files and making payments for each chunk individually, now the files are chunked only once and stored using thechunk_and_pay_for_storagefunction from thewallet.rsfile. Theupload_filefunction has been renamed toupload_chunksto reflect this change.The
upload_filesfunction now takes care of storing the chunks and generating the proofs for payment. It also creates a directory to store the uploaded files and saves information about the uploaded files in a file for future reference.The
chunk_and_pay_for_storagefunction in thewallet.rsfile has been modified to accommodate the changes in thefiles.rsfile. It now takes an additional parameterpayto indicate whether payment should be made for storage. It chunks the files, stores the chunks, and generates the payment proofs ifpayis true.Overall, these changes improve the efficiency of chunking and storing files by reducing the number of times chunks are created and payments are made.