Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): add marker for a network connection timeout #577

Merged
merged 1 commit into from Jul 31, 2023

Conversation

aed900
Copy link
Contributor

@aed900 aed900 commented Jul 26, 2023

Added a NetworkConnectionTimedOut marker/error message if connection is timed out.

Closes #518

@reviewpad reviewpad bot added the Small Pull request is small label Jul 26, 2023
@aed900 aed900 requested review from joshuef and b-zee July 26, 2023 15:58
@aed900 aed900 force-pushed the connmarkers3 branch 4 times, most recently from 64eccf1 to ca099aa Compare July 27, 2023 08:06
sn_node/src/api.rs Outdated Show resolved Hide resolved
@aed900 aed900 requested a review from joshuef July 27, 2023 17:17
@aed900 aed900 changed the title feat(node): add markers for initial connection attempt/timeout feat(node): add marker for a network connection timeout Jul 27, 2023
@aed900 aed900 force-pushed the connmarkers3 branch 6 times, most recently from f7d9ae3 to 5b677a8 Compare July 28, 2023 15:17
@aed900 aed900 marked this pull request as ready for review July 31, 2023 08:22
sn_node/src/api.rs Outdated Show resolved Hide resolved
sn_node/src/log_markers.rs Outdated Show resolved Hide resolved
sn_node/src/api.rs Outdated Show resolved Hide resolved
Added a NetworkConnectionTimedOut marker/error message if connection is timed out.
@joshuef joshuef enabled auto-merge July 31, 2023 11:24
@joshuef joshuef added this pull request to the merge queue Jul 31, 2023
Merged via the queue into maidsafe:main with commit 0945d8d Jul 31, 2023
19 of 20 checks passed
@aed900 aed900 deleted the connmarkers3 branch August 12, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Messaging around failure to connect
2 participants