fix(testnet): provide bootstrap peer when launching faucet #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where, when we try to launch a testnet with
local-discoveryturned off, the faucet cannot connect to the network as there is no bootstrap peer provided.Description
Summary generated by Reviewpad on 09 Aug 23 10:23 UTC
This pull request fixes a bug in the testnet code where a bootstrap peer was not being provided when launching the faucet. The
run_faucetfunction now takes an additional parametergen_multi_addrwhich is the MultiAddr of the genesis node. Therun_networkfunction now returns thegen_multi_addras aString.