feat(node): add feature flag for tcp/quic #630
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ); | ||
| } else { | ||
| assert_eq!( | ||
| format!("/ip4/127.0.0.1/udp/11101/quic-v1/p2p/{}", peer_id), |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
|
|
||
| if !cfg!(feature = "quic") { | ||
| assert_eq!( | ||
| format!("/ip4/127.0.0.1/tcp/11101/p2p/{}", peer_id), |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
| ); | ||
| } else { | ||
| assert_eq!( | ||
| format!("/ip4/127.0.0.1/udp/11101/quic-v1/p2p/{}", peer_id), |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
| ); | ||
| if !cfg!(feature = "quic") { | ||
| assert_eq!( | ||
| format!("/ip4/127.0.0.1/tcp/11101/p2p/{}", peer_id), |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
aed900
force-pushed
the
tcpquicfeatflag
branch
2 times, most recently
from
27fa316
to
dc9e9c5
Compare
aed900
force-pushed
the
tcpquicfeatflag
branch
from
dc9e9c5
to
c9a79cc
Compare
| let genesis_multi_addr = format!("/ip4/127.0.0.1/tcp/{:?}/p2p/{}", genesis_port, peer_id); | ||
| #[cfg(feature = "quic")] | ||
| let genesis_multi_addr = format!( | ||
| "/ip4/127.0.0.1/udp/{:?}/quic-v1/p2p/{}", |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
Nice one, thanks @aed900 ! 🙇 |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Added a feature flag to be able to toggle quic instead of the tcp default.
Refactored code related to the "add feature flag for tcp/quic" commit for this PR.
RolandSherwin
force-pushed
the
tcpquicfeatflag
branch
from
39d030a
to
b47595b
Compare
Added a feature flag to be able to toggle quic instead of the tcp default.