fix(network): reject large records before sending out to network #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -304,7 +309,7 @@ | |||
| } | |||
|
|
|||
| let store_cfg = DiskBackedRecordStoreConfig { | |||
| max_value_bytes: 1024 * 1024, | |||
| max_value_bytes: MAX_PACKET_SIZE, // TODO, does this need to be _less_ than MAX_PACKET_SIZE | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
RolandSherwin
force-pushed
the
set_max_packet_size
branch
from
ce320b3
to
ccfaeeb
Compare
RolandSherwin
force-pushed
the
set_max_packet_size
branch
from
ccfaeeb
to
db42d45
Compare
| @@ -68,6 +68,11 @@ | |||
| /// The peer should be present among the CLOSE_GROUP_SIZE if we're fetching the close_group(peer) | |||
| pub const CLOSE_GROUP_SIZE: usize = 8; | |||
|
|
|||
| /// What is the largest packet to send over the network. | |||
| /// Records larger than this will be rejected. | |||
| // TODO: revisit once utxo is in | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
maqi
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max kademlia packet size, it was previously rejected without any error. So send out an error on such cases.max kad packet sizefrom1MB -> 2MB. The chunk size is 1mb, so this should prevent any potential failures in the current network.Summary generated by Reviewpad on 22 Aug 23 16:19 UTC
This pull request includes several changes to the network module.
MAX_PACKET_SIZEto define the largest packet size to send over the network. Records larger than this size will be rejected.DiskBackedRecordStoremodule.Overall, these changes aim to improve the robustness and reliability of the network module by rejecting large records and handling errors more effectively.