feat(networking): single connection per direction #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-zee
force-pushed
the
feat-one-connection-per-direction
branch
from
5452b09
to
41d85b7
Compare
|
Closing as there are a few tests failing on CI with this PR. It seems there needs to be some more thought going into this and at the moment it's not a priority at all as the total amount of connections seem relatively low. (Although weeks ago we had some situations that were a little worrying with more than say 5 connections between peers.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the node dials peers for various reasons, this might be a dial while we already have an established connection. This isn't too much of a problem usually, but an optimization is to check for previously established connections and deny it if we already have one. This shouldn't alter any behaviour or cause errors to appear.