PPC data location debug #672
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -784,7 +810,13 @@ | |||
| /// Retry up to `PUT_RECORD_RETRIES` times if we can't verify the record is stored | |||
| async fn put_record_with_retries(&self, record: Record) -> Result<()> { | |||
| let mut retries = 0; | |||
| // TODO: Move this put retry loop up above store cost checks so we can re-put if storecost failed. | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @@ -76,5 +83,6 @@ | |||
| #[derive(Debug, Eq, PartialEq, Clone, Serialize, Deserialize)] | |||
| pub struct ChunkWithPayment { | |||
| pub chunk: Chunk, | |||
| pub payment: PaymentProof, | |||
| /// TODO: encrypt this or supply only encrypted derivation index | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| addr_name, | ||
| reason: err.to_string(), | ||
| })?; | ||
| // TODO: properly verify which one of these was for this node, and check _that_ |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| assert!(matches!( | ||
| verify_fee_output_and_proof(name, network_store_cost, &tx, audit_trail, &[]), | ||
| Err(err) if err == ProtocolError::PaymentProofInvalidFeeOutput(invalid_fee_id))); | ||
| // TODO: sort out what is acceptable based on the network store cost |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| inputs: vec![], | ||
| outputs: vec![], | ||
| outputs: tx_payments.clone(), | ||
| // TODO: Clean this up when we remove FeeOutput |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| return Err(ProtocolError::PaymentProofInsufficientAmount { paid, expected }); | ||
| // the fee output the expected `acceptable_fee` nano per record. | ||
| for output in tx.outputs.iter() { | ||
| // TODO: Is an output |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| "Trust replicated spend for {:?}", | ||
| PrettyPrintRecordKey::from(key.clone()) | ||
| ); | ||
| // TODO: may need to tweak the `signed_spend_validation` function, |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
Reviewpad Report
starting to simplify payments to a per chunk basis A first step in #638' (321cd19)
|
RolandSherwin
force-pushed
the
ppc_data_loc_debug
branch
6 times, most recently
from
7566998
to
1c09bac
Compare
starting to simplify payments to a per chunk basis A first step in maidsafe#638
Sets us up to pay every node that will be storing the data. We GetStoreCost and pay to their key, and put the chunk with the DBCs This is not yet validated at the node side
This gives maximal resilience as a place to start. (This is required for data location verification tests eg)
Use semaphore to allow uploads in parallel over many files instead of limiting it to chunks within a given file
with DBC parsing/passing mem is higher at the moment. This should be reduce as we move to make use of UTXOs
RolandSherwin
force-pushed
the
ppc_data_loc_debug
branch
from
1ec9877
to
e088905
Compare
|
Closed in favour of #674 |
Description
reviewpad:summary