Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ci): isolate nodes rewards test run to prevent from unrelated rewards #704

Merged
merged 1 commit into from Sep 4, 2023

Conversation

bochaco
Copy link
Member

@bochaco bochaco commented Sep 4, 2023

Description

Summary generated by Reviewpad on 04 Sep 23 14:47 UTC

This pull request adds a test for isolating nodes rewards run to prevent from unrelated rewards. It modifies the .github/workflows/merge.yml and .github/workflows/nightly.yml files to execute the nodes rewards tests. It also adds a new test file sn_node/tests/nodes_rewards.rs that tests nodes rewards for storing chunks. The existing test file sn_node/tests/storage_payments.rs is modified to remove the nodes rewards test.

@reviewpad reviewpad bot added the Medium Medium sized PR label Sep 4, 2023
@bochaco bochaco changed the title test(ci): isolate nodes rewards run to prevent from unrelated rewards test(ci): isolate nodes rewards test run to prevent from unrelated rewards Sep 4, 2023
@bochaco bochaco force-pushed the test-isolate-rewards-test-in-ci branch 2 times, most recently from b18a798 to 28b0ba9 Compare September 4, 2023 14:51
@bochaco bochaco force-pushed the test-isolate-rewards-test-in-ci branch from 28b0ba9 to d099105 Compare September 4, 2023 17:34
@bochaco bochaco marked this pull request as ready for review September 4, 2023 17:34
@reviewpad reviewpad bot requested a review from joshuef September 4, 2023 17:34
@joshuef joshuef added this pull request to the merge queue Sep 4, 2023
Merged via the queue into maidsafe:main with commit bfecd5d Sep 4, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium Medium sized PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants