refactor: Network related code #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
force-pushed
the
refactor_network
branch
from
194f8ed
to
792024d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }); | ||
| } | ||
| NodeRecordStoreConfig { | ||
| max_value_bytes: MAX_PACKET_SIZE, // TODO, does this need to be _less_ than MAX_PACKET_SIZE |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
|
||
| /// What is the largest packet to send over the network. | ||
| /// Records larger than this will be rejected. | ||
| // TODO: revisit once utxo is in |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
Merged
joshuef
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 04 Sep 23 14:51 UTC
This pull request includes changes in multiple files. Here's a summary of the changes:
The
sn_networking/src/msg/mod.rsfile has been deleted.The
sn_networking/src/event.rsfile has several changes, including imports reordering, removal of unnecessary imports, addition of a constant, replacement of a struct with a derive macro, addition of a variant to an enum, modification of a struct's implementation, addition of a new method, and removal of a method.The
record_store.rsfile has undergone several changes, including removal of unused modules, removal of constants, modification of a struct's fields, removal of unused imports and variables, and addition of a new import.Please review these changes for any possible impacts on the functionality of the affected files.