Enable node metrics #723
Merged
Enable node metrics #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewpad Report
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const METRICS_CONTENT_TYPE: &str = "application/openmetrics-text;charset=utf-8;version=1.0.0"; | ||
|
|
||
| pub(crate) fn run_metrics_server(registry: Registry) { | ||
| // Serve on localhost. |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
sn_networking/src/metrics_service.rs
Outdated
| fn respond_with_404_not_found(&mut self) -> Response<String> { | ||
| let mut resp = Response::default(); | ||
| *resp.status_mut() = StatusCode::NOT_FOUND; | ||
| *resp.body_mut() = "Not found try localhost:[port]/metrics".to_string(); |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
RolandSherwin
force-pushed
the
custom_metrics
branch
5 times, most recently
from
c3b0068
to
03590a4
Compare
| // Serve on localhost. | ||
| let addr = ([127, 0, 0, 1], 0).into(); | ||
|
|
||
| tokio::spawn(async move { | ||
| let server = Server::bind(&addr).serve(MakeMetricService::new(registry)); | ||
| info!("Metrics server on http://{}/metrics", server.local_addr()); | ||
| println!("Metrics server on http://{}/metrics", server.local_addr()); |
Check warning
Code scanning / devskim
An HTTP-based URL without TLS was detected. Warning
RolandSherwin
force-pushed
the
custom_metrics
branch
from
03590a4
to
adfff42
Compare
- this allows us to enable feature flagged fields to be passed in
RolandSherwin
force-pushed
the
custom_metrics
branch
from
adfff42
to
a2362a4
Compare
joshuef
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #705
Description
Summary generated by Reviewpad on 12 Sep 23 10:03 UTC
This pull request includes several changes across multiple files:
sn_networking/src/error.rsfile introduces new variants to theErrorenum related to error handling and network metrics.sn_node/src/metrics.rsfile adds functionality for collecting and recording metrics for the SAFE Network software.sn_node/src/node.rsfile includes changes to support the open-metrics feature, refactor network creation, handle network events, and record metrics.sn_node/src/api.rsfile adds support for metrics using theopen-metricsfeature, replaces theSwarmDriverimplementation, and adds methods for request timeout and concurrency limit.sn_node/src/metrics_service.rsfile adds a metrics server using the Hyper crate and implements theMetricServicestruct to handle incoming requests.Cargo.tomlfiles include changes related to new dependencies, features, and versions.These changes enhance error handling, network metrics, metrics collection and recording, network creation, API functionality, dependency management, and documentation.
Let me know if you need more information or have any questions.