chore(client): remove unused wallet_client #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems these parameters are no longer used, and they make API more complex. Perhaps they can be removed?
Description
Summary generated by Reviewpad on 14 Sep 23 19:52 UTC
This pull request removes the unused
wallet_clientparameter from theupload_with_paymentsfunction in theFilesstruct in thefile_apis.rsfile. It also removes the usage of this parameter in theupload_bytesfunction. Additionally, theupload_with_paymentsfunction calls in thenodes_rewards.rs,storage_payments.rs, andverify_data_location.rstest files have been updated to remove thewallet_clientparameter. These changes simplify the code by removing unnecessary dependencies.