New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: output address of uploaded file #733
Conversation
I actually think instead of 050103b we should just make that file human readable.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove 050103b
I'd rather we made the file human readable and that was how you can check. Doesn't feel like it needs to be in the cli to me.
OK cool. Serialize to JSON? |
Just a space separated list perhaps? (newline per file?) We could do json, but not sure it's worth it... treat yourself as the consumer of this (you are!) so whatever seems best! |
9759c69
to
46b7e64
Compare
46b7e64
to
cde1986
Compare
4d04ce3
to
ba4809e
Compare
Other minor adjustments for more compact text output.
Gives the user to list the files they have uploaded, along with their addresses. We were storing this data anyway, but it's serialized to binary, so it's not human readable. A little interface on the client could be useful for users.
The documentation for the arguments for the command are clarified, and we introduce a failure if only one of the name/address pair is used, as both are necessary. Also fix up some code from a complicated rebase.
For the uploaded files list, rather than serialize to binary, we use a simple text format. The user can now see the addresses of all the files they've uploaded, and use this information to retrieve them, if need be. We are also now just using one file, appending to it for each upload. Now that this file is human readable, the `files ls` command was deemed unnecessary and was therefore removed. With respect to the `files` commands, I've also taken the opportunity to make the language in the text output more concise and matter of fact. For example, we don't really need to use things like exclamation marks in the text.
ba4809e
to
e1a63bd
Compare
b8487f4 chore: output address of uploaded file
Other minor adjustments for more compact text output.
b5666ce feat: provide a
files ls
commandGives the user to list the files they have uploaded, along with their addresses. We were storing
this data anyway, but it's serialized to binary, so it's not human readable. A little interface on
the client could be useful for users.
bdfd4f7 chore: clarify
files download
usageThe documentation for the arguments for the command are clarified, and we introduce a failure if
only one of the name/address pair is used, as both are necessary.
Also fix up some code from a complicated rebase.
ba4809e chore: store uploaded files list as text
For the uploaded files list, rather than serialize to binary, we use a simple text format. The user
can now see the addresses of all the files they've uploaded, and use this information to retrieve
them, if need be. We are also now just using one file, appending to it for each upload.
Now that this file is human readable, the
files ls
command was deemed unnecessary and wastherefore removed.
With respect to the
files
commands, I've also taken the opportunity to make the language in thetext output more concise and matter of fact. For example, we don't really need to use things like
exclamation marks in the text.
Description
Summary generated by Reviewpad on 15 Sep 23 21:01 UTC
This pull request includes the following changes:
In
cli.rs
:timeout
field.concurrency
field.no_verify
field.In
main.rs
:FilesCmds
variant,Ls
, which lists all files uploaded by the current user.Ls
variant in thefiles_cmds
function.In
files.rs
:FilesCmds
variant,Ls
, which lists all files uploaded by the current user.offline_files_cmds
, which handles theLs
variant when offline.Ls
variant in thefiles_cmds
function.list_files
, which lists all files uploaded by the current user.In
file_apis.rs
:In
wallet.rs
: