New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dusking dbcs #747
Merged
Merged
feat: dusking dbcs #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
force-pushed
the
dusking_dbcs
branch
2 times, most recently
from
September 20, 2023 07:07
5e3dc19
to
95a0de6
Compare
joshuef
reviewed
Sep 20, 2023
joshuef
reviewed
Sep 20, 2023
grumbach
commented
Sep 20, 2023
grumbach
commented
Sep 20, 2023
grumbach
force-pushed
the
dusking_dbcs
branch
from
September 20, 2023 12:18
0ffdda9
to
b5013d9
Compare
joshuef
force-pushed
the
dusking_dbcs
branch
from
September 20, 2023 13:57
640ffd1
to
af0f12e
Compare
Is |
joshuef
force-pushed
the
dusking_dbcs
branch
from
September 20, 2023 14:13
af0f12e
to
3c6a64f
Compare
This change in nomenclature will be elaborated upon a dev update 👍 . But to be clear: this PR has no changes to how tokens and transfers operate on the network over the previous |
joshuef
force-pushed
the
dusking_dbcs
branch
from
September 20, 2023 14:20
3c6a64f
to
877b0df
Compare
joshuef
approved these changes
Sep 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 21, 2023
grumbach
force-pushed
the
dusking_dbcs
branch
3 times, most recently
from
September 21, 2023 07:41
27d9506
to
59e957b
Compare
grumbach
force-pushed
the
dusking_dbcs
branch
2 times, most recently
from
September 21, 2023 08:40
0c1632b
to
11b39ee
Compare
BREAKING CHANGE: DBCs and associated names are gone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sn_dbc
code insn_transfers
gets rid of DBCs and uses the new nomenclature:
SNT
: the unit of our currencyNanoTokens
: (currently Token) 10^-9 SNTCashNote
: (currently DBC), spendable unique key along with spend related information, containing n nanos. This CashNote contains unique key related information, leaking it damages privacy but it cannot be spent by an attacker since it doesn’t contain your private key.Spend
/SignedSpend
: Network representation of a spent CashNote, it cannot be linked back to your MainKey. It makes the system auditable and transactions verifiableTransaction
: (currently DbcTransaction), Network operation that creates new CashNote while spending CashNote of the same total value, transaction information is findable both in CashNotes and in the Spends on the Network.CashNoteRedemption
: (currently UTXO) minimal information from which the recipient of a Transaction can redeem their new spendable CashNoteTransfer
: encrypted NoteRedemptions ready to be sent to a transaction recipient so they can receive money.As for keys:
MainSecretKey
: (current MainKey) the private main key (secret)DerivedSecretKey
: (current DerivedKey) a derived key from the main key (IS UNIQUE but secret)MainPubkey
: (current PublicAddress) the public key of the main keyUniquePubkey
: (current dbc_id) the public key of the derived key (IS UNIQUE)Description
reviewpad:summary