Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dusking dbcs #747

Merged
merged 10 commits into from Sep 21, 2023
Merged

feat: dusking dbcs #747

merged 10 commits into from Sep 21, 2023

Conversation

grumbach
Copy link
Member

@grumbach grumbach commented Sep 20, 2023

  • includes sn_dbc code in sn_transfers

gets rid of DBCs and uses the new nomenclature:

  • SNT: the unit of our currency
  • NanoTokens : (currently Token) 10^-9 SNT
  • CashNote: (currently DBC), spendable unique key along with spend related information, containing n nanos. This CashNote contains unique key related information, leaking it damages privacy but it cannot be spent by an attacker since it doesn’t contain your private key.
  • Spend/SignedSpend: Network representation of a spent CashNote, it cannot be linked back to your MainKey. It makes the system auditable and transactions verifiable
  • Transaction: (currently DbcTransaction), Network operation that creates new CashNote while spending CashNote of the same total value, transaction information is findable both in CashNotes and in the Spends on the Network.
  • CashNoteRedemption: (currently UTXO) minimal information from which the recipient of a Transaction can redeem their new spendable CashNote
  • Transfer: encrypted NoteRedemptions ready to be sent to a transaction recipient so they can receive money.

As for keys:

  • MainSecretKey: (current MainKey) the private main key (secret)
  • DerivedSecretKey: (current DerivedKey) a derived key from the main key (IS UNIQUE but secret)
  • MainPubkey: (current PublicAddress) the public key of the main key
  • UniquePubkey: (current dbc_id) the public key of the derived key (IS UNIQUE)

Description

reviewpad:summary

@grumbach grumbach force-pushed the dusking_dbcs branch 2 times, most recently from 5e3dc19 to 95a0de6 Compare September 20, 2023 07:07
sn_transfers/src/cashnote.rs Dismissed Show dismissed Hide dismissed
sn_transfers/src/lib.rs Dismissed Show dismissed Hide dismissed
sn_transfers/src/genesis.rs Dismissed Show dismissed Hide dismissed
sn_networking/src/driver.rs Dismissed Show dismissed Hide dismissed
@happybeing
Copy link
Contributor

Is CashNote straying away from utility token and towards money?

@joshuef
Copy link
Contributor

joshuef commented Sep 20, 2023

Is CashNote straying away from utility token and towards money?

This change in nomenclature will be elaborated upon a dev update 👍 .

But to be clear: this PR has no changes to how tokens and transfers operate on the network over the previous dbc crate. It's all being rolled in here and naming updated to better reflect what's actually happening

@joshuef joshuef added this pull request to the merge queue Sep 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2023
@grumbach grumbach added this pull request to the merge queue Sep 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 21, 2023
@grumbach grumbach added this pull request to the merge queue Sep 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 21, 2023
@joshuef joshuef added this pull request to the merge queue Sep 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 21, 2023
@grumbach grumbach force-pushed the dusking_dbcs branch 3 times, most recently from 27d9506 to 59e957b Compare September 21, 2023 07:41
@grumbach grumbach force-pushed the dusking_dbcs branch 2 times, most recently from 0c1632b to 11b39ee Compare September 21, 2023 08:40
@grumbach grumbach added this pull request to the merge queue Sep 21, 2023
@joshuef joshuef removed this pull request from the merge queue due to a manual request Sep 21, 2023
@joshuef joshuef added this pull request to the merge queue Sep 21, 2023
Merged via the queue into maidsafe:main with commit 163381b Sep 21, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants