feat(cli): fetch bootstrap peers from network contacts #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
added
Small
|
Reviewpad Report
|
jacderida
reviewed
Sep 20, 2023
RolandSherwin
force-pushed
the
protoc
branch
4 times, most recently
from
db574b8
to
c49f614
Compare
- also remove the feature gate
- also enable network-contact feature flag for testnet bin
Add example network contacts file
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
joshuef
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 20 Sep 23 14:48 UTC
This pull request introduces a new feature to the CLI by fetching bootstrap peers from network contacts. It modifies the
Cargo.tomlfile to add thenetwork-contactsfeature, and it updates themain.rsfile to handle the fetching and parsing of bootstrap peers from a network contacts file stored in S3.