feat: deep clean sn_transfers, reduce exposition, remove dead code #773

grumbach · 2023-09-26T13:20:48Z

remove lots of dead code
reduce variable exposition in sn_transfers, hide TransactionBuilder and other implementation details
make exposed types explicit all in sn_transfers lib.rs, all modules now private
rewrite benchmarks with the more high level exposed API

BREAKING CHANGE: sn_transfers type API exposision changes

Description

reviewpad:summary

sn_transfers/src/reason_hash.rs

BREAKING CHANGE: sn_transfers type API exposision changes

sn_transfers/benches/reissue.rs

sn_transfers/Cargo.toml

reviewpad bot requested a review from bochaco September 26, 2023 13:21

reviewpad bot added Large Large sized PR waiting-for-review labels Sep 26, 2023

github-advanced-security bot found potential problems Sep 26, 2023

View reviewed changes

sn_transfers/src/reason_hash.rs Dismissed Show dismissed Hide dismissed

feat: deep clean sn_transfers, reduce exposition, remove dead code

42d3346

BREAKING CHANGE: sn_transfers type API exposision changes

grumbach force-pushed the clean_sn_transfers_api branch from 9901d12 to 42d3346 Compare September 26, 2023 13:23

chore: udeps

ee4f3b0

b-zee reviewed Sep 27, 2023

View reviewed changes

sn_transfers/benches/reissue.rs Outdated Show resolved Hide resolved

b-zee reviewed Sep 27, 2023

View reviewed changes

sn_transfers/Cargo.toml Outdated Show resolved Hide resolved

grumbach added 2 commits September 27, 2023 15:46

fix: uncomment benches in Cargo.toml

53acbd8

chore: improve cloning

7e56e57

grumbach enabled auto-merge September 27, 2023 06:49

grumbach added 2 commits September 27, 2023 16:11

chore: optimise bench

a176e3a

fix: benches

3f5d57a

b-zee approved these changes Sep 27, 2023

View reviewed changes

grumbach added this pull request to the merge queue Sep 27, 2023

Merged via the queue into maidsafe:main with commit e1f251a Sep 27, 2023
28 checks passed

grumbach deleted the clean_sn_transfers_api branch September 27, 2023 10:34