feat(client): fail fast when a chunk is missing #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 27 Sep 23 09:22 UTC
This pull request adds a feature to the client where it fails fast when a chunk is missing. It includes changes to the
sn_client/src/chunks/error.rsandsn_client/src/file_apis.rsfiles. Overall, the patch adds 26 insertions and removes 39 deletions. The changes include adding a new error variant for a missing chunk in theErrorenum, modifying theFilesstruct to handle missing chunks and update progress, and handling missing chunks in the file download process.