feat: all records are Quorum::All once more #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
force-pushed
the
RemoveCaching
branch
from
0a1a920
to
5388289
Compare
reviewpad
bot
added
Medium
maqi
approved these changes
Sep 27, 2023
| let mut _permit = starting_permit; | ||
| async fn put_record_once(&self, record: Record, verify_store: Option<Record>) -> Result<()> { | ||
| // get permit if semaphore supplied | ||
| let _permit = if let Some(semaphore) = self.concurrency_limiter.clone() { |
There was a problem hiding this comment.
just to confirm so here we no longer consume the fetched permit, but leave it to be dropped when the whole function call completed ?
There was a problem hiding this comment.
we hold it until the PUT is done, which is what was happening before with an optionally passed permit.
(which should have just be grabbed above)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 27 Sep 23 10:29 UTC
This pull request includes changes in multiple files. Here are the key changes:
sn_client/src/api.rs, the functionget_network_concurrency_permithas been removed.sn_client/src/api.rs, the functionstore_chunkhas been updated to remove the optional parameteroptional_permit.sn_client/src/api.rs, the functionget_chunkhas been updated to remove the optional parameteroptional_permit.sn_client/src/file_apis.rs, the functionstore_chunkhas been updated to remove the optional parameteroptional_permit.sn_client/src/file_apis.rs, the functionget_local_payment_and_upload_chunkhas been updated to remove the optional parameteroptional_permit.sn_client/src/register.rs, the functionput_registerhas been updated to remove the optional parameterquorum.sn_networking/src/cmd.rs, the variantPutRecordof theSwarmCmdenum has been updated to remove the fieldquorum.sn_networking/src/driver.rs, the functionNetworkBuilder::build_kademliahas been updated to remove the caching configuration.sn_networking/src/lib.rs, the functionNetwork::put_recordhas been updated to remove the parametersoptional_permitandquorum.sn_networking/src/lib.rs, the functionNetwork::put_record_oncehas been updated to remove the parametersstarting_permitandquorum.Please review these changes and ensure that they align with the intended functionality and requirements.