New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): dockerized grafana dashboard to visualize node metrics #796
Conversation
153fdaf
to
093639c
Compare
9eb0ff5
to
682b697
Compare
@@ -19,8 +19,8 @@ | |||
const METRICS_CONTENT_TYPE: &str = "application/openmetrics-text;charset=utf-8;version=1.0.0"; | |||
|
|||
pub(crate) fn run_metrics_server(registry: Registry) { | |||
// Serve on localhost. | |||
let addr = ([127, 0, 0, 1], 0).into(); | |||
// The server should not bind to localhost/127.0.0.1 as it will not accept connections from containers. |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
@@ -19,8 +19,8 @@ | |||
const METRICS_CONTENT_TYPE: &str = "application/openmetrics-text;charset=utf-8;version=1.0.0"; | |||
|
|||
pub(crate) fn run_metrics_server(registry: Registry) { | |||
// Serve on localhost. | |||
let addr = ([127, 0, 0, 1], 0).into(); | |||
// The server should not bind to localhost/127.0.0.1 as it will not accept connections from containers. |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
9eb0f62
to
be608f2
Compare
be608f2
to
767d1d0
Compare
767d1d0
to
cae0218
Compare
Description
The
./metrics/readme.md
contains the steps to start the dashboard. Should be as simple as executing a single command.Summary generated by Reviewpad on 04 Oct 23 11:33 UTC
This pull request includes the following changes:
The
Cargo.toml
file:The
Cargo.lock
file:The
metrics/README.md
file:The
metrics/Cargo.toml
file:walkdir
dependency has been updated.The
metrics/dashboard.yml
file:The
metrics/docker-compose.yml
file:The
lib.rs
file:The
event.rs
file:The
main.rs
file:Please review these changes carefully and ensure they are intended. Let me know if you need more information or have any questions.