fix: consider record split an error, handle it for regs #838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consider records split (when we receive different values from different nodes for the same key) an error instead of accepting the most popular one.
A split means:
GetQuorum::One
so this error doesn't happenThis PR considers this situation to be an error, except for Registers where this error is handled on the client side, which merges the registers into one.
Summary generated by Reviewpad on 16 Oct 23 08:58 UTC
This pull request includes several changes across multiple files.
In the
Cargo.toml
file, a new dependency on "eyre" has been added.In the
sn_networking/src/error.rs
file, there are changes related to imports, type aliases, and the addition of a new variant to theError
enum.In another file, there are changes related to imports, method modifications, and formatting comments.
Lastly, in a different file, there are changes related to imports, the addition of new functions, and the implementation of a new struct.
Overall, the diff includes various changes improving dependency management, error handling, and register handling in the project.