fix(network): emit NetworkEvent when we publish a gossipsub msg #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- should fix the reward test failures - they were cuased because the `genesis_node` that we used to monitor the gossipsub messages from was the one who published the message - Hence it would not emit and `NodeEvent` that we were listening for
|
Reviewpad Report
|
joshuef
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
genesis_nodethat we used to monitor the gossipsub messages from, was the one who published the message.NodeEventthat we were listening for.Description
Summary generated by Reviewpad on 19 Oct 23 10:05 UTC
This pull request fixes an issue with the rewards test failures by emitting a NetworkEvent when a gossipsub message is published. The previous issue was caused because the
genesis_nodethat was used to monitor the gossipsub messages also published the message, resulting in the event not being emitted and causing failures. The patch adds theGossipsubMsgPublishedevent to notify that a message has been published.