feat: log network address with KBucketKey #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
changed the title
maqi
force-pushed
the
logging_with_kbucketKey
branch
2 times, most recently
from
15d2911
to
e7da728
Compare
maqi
changed the title
maqi
force-pushed
the
logging_with_kbucketKey
branch
from
e7da728
to
ca3910c
Compare
maqi
force-pushed
the
logging_with_kbucketKey
branch
from
ca3910c
to
723651b
Compare
joshuef
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 20 Oct 23 07:38 UTC
This pull request adds a feature to log the network address with KBucketKey in several files. It modifies the
driver.rs,lib.rs,replication.rs, andlib.rsfiles, adding thePrettyPrintKBucketKeystruct and updating the log statements to use it for pretty printing the KBucketKey. The patch also updates the import statements accordingly. Overall, this pull request improves the logging functionality related to network addresses.