NoStoreCost if existing #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
changed the title
|
Reviewpad Report
|
This means clients wont keep repaying for data already stored somewhere. And so should make repayment/updates simpler and hopefully prevent looping over ever increasing prices (when those nodes already have the data stored)
joshuef
force-pushed
the
NoStoreCostIfRecordExists
branch
from
f69cda1
to
e791d14
Compare
joshuef
force-pushed
the
NoStoreCostIfRecordExists
branch
from
7280568
to
63a2316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shoudl be sufficient with replication increased.## Description
Summary generated by Reviewpad on 21 Oct 23 13:17 UTC
This pull request includes two patches.
The first patch is a chore to the client, specifically in the
api.rsfile. It changes theGetQuorumparameter in theget_record_from_networkfunction call fromGetQuorum::AlltoGetQuorum::Majority. This change is made to ensure that chunks only reach the majority in replication scenarios.The second patch is a feature addition to the protocol, involving multiple files. It allows nodes to error
StoreCostsif they already have the data. This change means that clients won't keep repaying for data that is already stored somewhere. It aims to simplify repayment/updates and prevent looping over ever-increasing prices when the nodes already have the data stored.Overall, these patches aim to improve the efficiency and reliability of the codebase.