chore: expand replication range #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
approved these changes
Oct 23, 2023
maqi
force-pushed
the
expand_replication_range
branch
from
523b990
to
366c2e8
Compare
reviewpad
bot
added
Large
joshuef
reviewed
Oct 24, 2023
sn_networking/src/record_store.rs
Outdated
| // Blindly sent to validation to allow double spend can be detected. | ||
| // TODO: consider avoid throw duplicated chunk to validation. | ||
| // Chunk with existing key do not to be stored again. | ||
| // `Spend` or `Register` with same content_hash do not to be stored again, |
There was a problem hiding this comment.
// SpendorRegister with same content_hash do not to be stored again,
do need to be stored no?
There was a problem hiding this comment.
that's for the case of same key AND same content_cash, so do not need to be stored again
RolandSherwin
approved these changes
Oct 25, 2023
maqi
force-pushed
the
expand_replication_range
branch
3 times, most recently
from
c90b054
to
40f814f
Compare
maqi
force-pushed
the
expand_replication_range
branch
from
fa7d9e6
to
bb157fc
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
maqi
force-pushed
the
expand_replication_range
branch
from
bb157fc
to
eb5f3ec
Compare
This reverts commit df8b357.
maqi
force-pushed
the
expand_replication_range
branch
from
eb5f3ec
to
5065a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 23 Oct 23 14:12 UTC
This pull request expands the replication range in the code. It modifies the
sn_networking/src/cmd.rs,sn_networking/src/lib.rs, andsn_node/src/replication.rsfiles. The changes include updating theREPLICATE_RANGEconstant to be twice theCLOSE_GROUP_SIZE, and using this new range in the code logic to determine whether a peer is in the close range. The patch also involves making adjustments to the replication process based on whether the target peer is a dead peer or a new peer.