feat(client): do not retry verification GETs #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either first attempt works, or we move on
joshuef
force-pushed
the
DoNotRetryVerificationGets
branch
from
40f56df
to
e8f809a
Compare
RolandSherwin
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either first attempt works, or we move on
Description
Summary generated by Reviewpad on 23 Oct 23 19:16 UTC
This pull request updates the client implementation in the
api.rsfile. Specifically, it modifies theget_record_from_networkfunction calls by changing the last parameter fromtruetofalse. This change ensures that verification GETs are not retried and instead either the first attempt works or the process moves on.