Make files upload output cut n paste friendly #891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naive attempt to address issue from https://safenetforum.org/t/heapnet2-testnet-12-10-23/38749/460?u=southside
try again
…er-friendly.
- println!("Uploaded {} to {:x}", file_name, addr);
+ println!("\"{}\" {:x}", file_name, addr);
info!("Uploaded {} to {:x}", file_name, addr);
|
Reviewpad Report
naive attempt to address issue from https://safenetforum.org/t/heapnet2-testnet-12-10-23/38749/460?u=southside' (a27d99f)
try again' (482648c)
|
|
Thanks @willief this is looking like a nice wee improvement. One of wee things: We use https://www.conventionalcommits.org/en/v1.0.0/ for commit messages. So would you mind to rebase the changes together into one commit using the above format? eg |
joshuef
approved these changes
Nov 2, 2023
|
merged via #891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 03 Nov 23 09:40 UTC
This pull request includes multiple patches to update the files.rs file in the sn_cli subcommands. The changes primarily involve updating the print statements and log messages related to file uploads. Some changes attempt to address specific issues mentioned in a forum thread. The patches also include whitespace cleanup and formatting changes, such as surrounding the file names with double quotes in print statements for better readability and user-friendliness.
#890
Make sharing upload results as easy as possible and encourage others to test downloads.
Change
Uploaded History of Stuff 1980-2023.pdf to 1d1e081fbf7b37f2156f3f428ead2ecb31f7b91b0a4239564eb426cffca65e0f
to
"History of Stuff 1980-2023.pdf" 1d1e081fbf7b37f2156f3f428ead2ecb31f7b91b0a4239564eb426cffca65e0f
This output then can be pasted directly into safe files download for immediate testing or can be quickly posted to an Uploads wiki page on the forum.