fix: return with majority #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
approved these changes
Oct 26, 2023
maqi
force-pushed
the
return_with_majority_on_split
branch
3 times, most recently
from
0c55d0b
to
32a3816
Compare
maqi
force-pushed
the
return_with_majority_on_split
branch
from
32a3816
to
1e600ec
Compare
maqi
force-pushed
the
return_with_majority_on_split
branch
from
1e600ec
to
a11da3a
Compare
reviewpad
bot
added
Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 24 Oct 23 15:15 UTC
This pull request fixes the issue of returning with the majority in the code. The changes include modifications in the
api.rs,error.rs, andevent.rsfiles. The patch ensures that when encountering a split record, the code returns with the majority copy instead of logging the wholeRecordcontent.