feat(cli): resume uploads across multiple safe runs
#907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
force-pushed
the
cli_resume
branch
5 times, most recently
from
1c0e56c
to
69b2294
Compare
RolandSherwin
changed the title
safe runssafe runs
RolandSherwin
force-pushed
the
cli_resume
branch
6 times, most recently
from
6abbb3d
to
3e1dd7a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // use the chunk_artifacts_dir directly; This should not result in any | ||
| // undefined behaviour. The resume operation will be disabled if we don't | ||
| // use the `path_xor` dir. | ||
| // TODO: maybe error out if we get any fs errors. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
joshuef
reviewed
Nov 6, 2023
sn_protocol/src/test_utils.rs
Outdated
|
|
||
| use std::fmt; | ||
|
|
||
| pub fn assert_lists<I, J, K>(a: I, b: J) |
There was a problem hiding this comment.
can you elaborate or add docs here?
There was a problem hiding this comment.
Added docs to that function.
There was a problem hiding this comment.
maybe assert_list_eq would be a better name?
RolandSherwin
force-pushed
the
cli_resume
branch
from
3e1dd7a
to
6ba193f
Compare
grumbach
reviewed
Nov 7, 2023
sn_cli/src/subcommands/files/mod.rs
Outdated
| .iter() | ||
| .map(|(file_addr, chunked_file)| (*file_addr, chunked_file.file_name.clone())) | ||
| .collect::<Vec<_>>(); | ||
| // Return early if we hav no files to pay/verify |
There was a problem hiding this comment.
Suggested change
| // Return early if we hav no files to pay/verify | |
| // Return early if we have no files to pay/verify |
…sString to String
RolandSherwin
force-pushed
the
cli_resume
branch
from
6ba193f
to
31f33f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 26 Oct 23 14:12 UTC
This pull request involves renaming the file "sn_cli/src/subcommands/files.rs" to "sn_cli/src/subcommands/files/mod.rs" and making changes to imports, module structure, function parameters, and method calls. Some code has been moved to a new module called "chunk_manager". The chunking functionality has been refactored and is now handled by the ChunkManager struct. The upload_files function has been modified to use the ChunkManager and no longer requires the wallet_dir_path parameter. The file_names_path has also been changed to use the root_dir. Some code related to logging has been commented out. Overall, the changes seem to improve the organization and modularity of the code.
The file
wallet.rshas undergone several changes. Here is a summary of the changes made:ChunkManagerfrom thefilesmodule.chunk_pathfrom thefilesmodule.wallet_dir_pathwithroot_dir.file_apiobject initialization withFiles::new(client.clone(), root_dir.to_path_buf()).chunk_pathfunction withmanager.chunk_path(&path)?.chunked_files.values()withmanager.get_chunks().iter().ChunkedFilestruct definition and its associated code.This file contains the implementation of a chunk manager, which is responsible for chunking files and managing the chunks. It includes several structs and methods for chunking files, storing chunk information, and retrieving chunks. The chunk manager takes a root directory and a files API as input and provides methods for chunking files, retrieving chunks, and marking finished chunks. The implementation uses external libraries such as color_eyre, rayon, sn_client, xor_name, walkdir for various functionalities.
Overall, this file provides the necessary functionality for chunking and managing files in the SAFE Network Software.
Please review these changes and consider their impact on the code. Let me know if you need more information.