refactor(node): short-circuit transfers verification once the first o… #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bochaco
force-pushed
the
refactor-short-circuit-transfers-verification
branch
4 times, most recently
from
34ee789
to
430e36b
Compare
…ne belonging to itself is found
…s receiver subscribed
… the NodeEventsChannel
bochaco
force-pushed
the
refactor-short-circuit-transfers-verification
branch
from
430e36b
to
f56f664
Compare
joshuef
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ne belonging to itself is found
Description
Summary generated by Reviewpad on 01 Nov 23 13:12 UTC
This pull request refactors the
put_validation.rsfile in thesn_nodeproject. The change introduces a short-circuit mechanism that skips further verification once the first transfer belonging to itself is found. This improves the overall efficiency of the code.