feat(sn_networking): no gossip for clients via Toggle #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-zee
approved these changes
Nov 21, 2023
reviewpad
bot
added
Medium
joshuef
force-pushed
the
NoClientGoss
branch
from
def5a2c
to
d1dfe44
Compare
maqi
approved these changes
Nov 21, 2023
joshuef
force-pushed
the
NoClientGoss
branch
from
2c08b14
to
1150839
Compare
sn_client/src/api.rs
Outdated
Comment on lines
82
to
83
| let (network, mut network_event_receiver, swarm_driver) = | ||
| network_builder.build_client(joins_gossip)?; |
There was a problem hiding this comment.
Just a small nit, but can we add enable_gossipsub into NetworkBuilder? And let it be false by default and enabled just for nodes?
joshuef
force-pushed
the
NoClientGoss
branch
from
aaf36a2
to
b8d4f07
Compare
joshuef
force-pushed
the
NoClientGoss
branch
from
b8d4f07
to
4ab1def
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 21 Nov 23 09:26 UTC
This pull request adds a feature to the sn_networking module. Specifically, it modifies the behavior of the Gossipsub protocol for clients. Gossiping is now disabled for clients via a Toggle. Additionally, the patch refactors the code related to the Gossipsub behavior and adds conditionals to handle different scenarios. The patch also includes various code cleanups and optimizations.