feat(cli): add download batch-size option #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
force-pushed
the
DownloadBatchSize
branch
from
899bc64
to
5665c9c
Compare
sn_client/src/file_apis.rs
Outdated
| @@ -426,7 +428,10 @@ impl Files { | |||
| return Ok(data_map); | |||
| } | |||
| DataMapLevel::Additional(data_map) => { | |||
| let serialized_chunk = self.read_all(data_map, None, false).await?.unwrap(); | |||
| let serialized_chunk = self | |||
| .read_all(data_map, None, false, BATCH_SIZE) | |||
There was a problem hiding this comment.
Can we pass the batch_size arg here instead of using the const?
RolandSherwin
approved these changes
Nov 22, 2023
Sets default to 1/4 of upload
joshuef
force-pushed
the
DownloadBatchSize
branch
from
99c6ca9
to
6790901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets default to 1/4 of upload
Description
Summary generated by Reviewpad on 22 Nov 23 09:07 UTC
This pull request adds a new option for the batch size in the command line interface (CLI) for parallel handling of chunks during payment and upload processing. Additionally, it also adds a batch size option for parallel downloading. The default value for the download batch size is set to one-fourth of the upload batch size. The changes are made in the
sn_cli/src/subcommands/files/mod.rsandsn_client/src/file_apis.rsfiles. The patch adds new command line options and modifies thefiles_cmdsfunction to handle the new batch size options. It also adds new functionsdownload_files,download_file, and modifies theverify_and_repay_if_needed_oncefunction to accommodate the new batch size option for parallel downloading.