Refactor unsigned integer types #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Last commit changed the argument types of the SE API
Merged
lionel-faber
approved these changes
Apr 13, 2021
|
The changes look good @kanav99 |
|
Yes, the second commit has these breaking tag! |
|
Ah nice one! Sorry I didn't notice it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still unsure about the implications in the cross-platform scenario. According to me, there should be no problem as the encryption function calls and types are unchanged, so the output should not be different for any architecture. But @dirvine says that there are special ramifications we need to be sure of. But I went ahead and changed everything to
usizeand see what happens. If there are certain issues, we can specifically cast them there. But overall, the code looks much more cleaner with no explicit type casts everywhere.